[EasyUO]TEST: KaianaUberLooter

If you make a Client-side script you can publish it here for other players to use
TheWatcher
Elder Scribe
Posts: 164
Joined: Wed Nov 11, 2009 12:15 am

Re: [EasyUO]TEST: KaianaUberLooter

Post by TheWatcher »

The only time I crash is when i get the error message "that is out of sight". DOnt know if that is a script or a client issue? This might be the case for a few people? For example in tera keep or destard there is a heap of hills that give the mesaage so i dont use the looter there......

Sometimes when collecting keys in travesty it gets the "action qued" message thingy. Sometimes as high has 50, i have to restart client then....
User avatar
Steve
Elder Scribe
Posts: 165
Joined: Sat May 08, 2010 5:23 pm

Re: [EasyUO]TEST: KaianaUberLooter

Post by Steve »

on a slightly related note...when i first tried easyuo, it used to outright crash my client as soon as i clicked play. then i found out i needed to upgrade my client, now im runing the pre-patch provided, but so are most of you guys :?

verry odd, and highly iritating...i realy realy want to be lazy ^_^
and ofc make a bit of cash while runing my weapon lvling macro.

If i do a fresh format (which i imagine to be sometime soon) i'll let you know if i have the same experiences, who knows, it could be specific hardware related.
User avatar
Kaiana
Elder Scribe
Posts: 148
Joined: Mon Jul 13, 2009 3:07 pm

Re: [EasyUO]TEST: KaianaUberLooter

Post by Kaiana »

Watcher, there is a variable in the script called %waitTime...try turning this up a bit. I forget what i have the default set to but I get a pretty good ping and if yours isn't as good then turning up the amount of time it waits between actions is probably a good idea. I can probably script in something to do this automatically later :p I used to have the problem you're describing all the time but I thought I had eliminated it.

And yes, I need to add a filter for when an item on a corpse is out of sight. For some reason if a corpse is out of sight but still within opening range you can open it but not loot from it (dumb on UO's part), and I forgot to script in something for that contingency. I'll fix that with the update :)

Anyway, for the %waitTime variable, 20 = 1 second...so 10 is half a second, etc. Set it to whatever works for you. The lowest possible setting that works is probably best.

I also read in another post that not having the registry set up correctly for UO can affect EasyUO...perhaps this is the problem. In the post at the top of this forum (Cliloc not found), there are some instructions on that. Maybe that will help? Not sure.
♥Kaiana♥ - Administrator of the Heart

Yay for scripting and programming! :)
public bool EasyUOMastery = true;
private double CSharpSkillz = 30.0; //and rising!
User avatar
Tael
Elder Scribe
Posts: 166
Joined: Sun May 17, 2009 1:44 am

Re: [EasyUO]TEST: KaianaUberLooter

Post by Tael »

Kaiana wrote:And yes, I need to add a filter for when an item on a corpse is out of sight. For some reason if a corpse is out of sight but still within opening range you can open it but not loot from it (dumb on UO's part), and I forgot to script in something for that contingency. I'll fix that with the update :)
This could explain the crash problems you mentioned in the cliloc thread.

I haven't looked at your script yet, but looting scripts I've used in the past were very touchy (at least on runuo shards) when dealing with targets that come in and out of range, which happens when you're looting and moving around. Scripts with heavy targeting in general will sometimes crash no matter what you do. You'll go crazy trying to debug this, because I'm pretty sure some of the bugs are in the client.

The best idea is to keep it as simple as possible -- for example, the script doesn't need to close corpses, so don't add that layer of complexity to it. But like I said, I haven't looked at the script yet, maybe I should do that now 8)
Taelwrath - noobus perpetuus
User avatar
Kaiana
Elder Scribe
Posts: 148
Joined: Mon Jul 13, 2009 3:07 pm

Re: [EasyUO]TEST: KaianaUberLooter

Post by Kaiana »

Closing corpses is an option on the menu ;) You can set it to not do that.

And actually aside from the out of sight bug I think the script works pretty well for moving out of range of corpses. :) I think when you try it you'll like it Tael...there's a sub in the script called GetStatus that checks if the character has moved, if the corpse is out of range, and many other things (see below) that you don't want to have going on with the looter doing its thing. If this sub returns a false for any reason, the corpse is skipped but not ignored. Meaning the script will come back to it if it re-enters your looting range or whatever else caused the false to return goes away.

This is everything it checks for before looting something:
-You are not dragging something
-You don't have a "how many" gump open (like when you start to drag a stackable without holding shift)
-You don't have a target cursor up
-You are logged in
-You are not a ghost
-You are not hidden (so it doesn't start looting while hidden and reveal you)
-You are not in combat (this is an option that can be turned off)
-Also tracks if you have been killed recently, and if so, will allow looting while hidden but ONLY of your player corpse...so as soon as you approach your corpse it will automatically open it and then return to normal looting mode

There is also a sub called CheckDist which is called almost every GetStatus and that determines if the corpse has left your range. :)

The issue is that stupid "That is out of sight." message. It only happens when a corpse is in range and opened but the game considers it "out of sight". I think this is a client bug because really if the corpse is out of sight you shouldn't be able to open it....but le sigh. I'll just make a bit of code for that in the next update ;)
♥Kaiana♥ - Administrator of the Heart

Yay for scripting and programming! :)
public bool EasyUOMastery = true;
private double CSharpSkillz = 30.0; //and rising!
Lairn
Novice Scribe
Posts: 5
Joined: Wed Oct 27, 2010 9:11 pm

Re: [EasyUO]TEST: KaianaUberLooter

Post by Lairn »

So I fixed my registry with Razor and the script worked great. Only time I crashed in the past 30 minutes was when I "out of range" and didn't move fast enough away I think. Its a really great script.
User avatar
Kaiana
Elder Scribe
Posts: 148
Joined: Mon Jul 13, 2009 3:07 pm

Re: [EasyUO]TEST: KaianaUberLooter

Post by Kaiana »

Just updated initial post with info and the revised script for version 0.91 :)

Keep up the good testing people! Let me know of any problems, as usual. I still haven't found a workaround for the "That is out of sight." issue, but I should have one by next update...I have some ideas.
♥Kaiana♥ - Administrator of the Heart

Yay for scripting and programming! :)
public bool EasyUOMastery = true;
private double CSharpSkillz = 30.0; //and rising!
User avatar
Tael
Elder Scribe
Posts: 166
Joined: Sun May 17, 2009 1:44 am

Re: [EasyUO]TEST: KaianaUberLooter

Post by Tael »

I intend to do some testing on your script this weekend. I read it through, and it looks pretty solid. The GetStatus sub is interesting. I'm pretty good at torture testing, so I'll let you know how it goes.

BTW, the looter I've always used up until now is this one ...
Taelwrath - noobus perpetuus
User avatar
Kaiana
Elder Scribe
Posts: 148
Joined: Mon Jul 13, 2009 3:07 pm

Re: [EasyUO]TEST: KaianaUberLooter

Post by Kaiana »

Argh, found some bugs with sub-container opening. Give me a bit to fix. Should be posted shortly.
♥Kaiana♥ - Administrator of the Heart

Yay for scripting and programming! :)
public bool EasyUOMastery = true;
private double CSharpSkillz = 30.0; //and rising!
User avatar
Kaiana
Elder Scribe
Posts: 148
Joined: Mon Jul 13, 2009 3:07 pm

Re: [EasyUO]TEST: KaianaUberLooter

Post by Kaiana »

Still having trouble....taking a break to clear my head :P I almost had it fixed but then realized another problem with the fix so arrrghh :P
♥Kaiana♥ - Administrator of the Heart

Yay for scripting and programming! :)
public bool EasyUOMastery = true;
private double CSharpSkillz = 30.0; //and rising!
ticketguru
Grandmaster Scribe
Posts: 99
Joined: Fri Jun 12, 2009 11:25 pm

Re: [EasyUO]TEST: KaianaUberLooter

Post by ticketguru »

Don't you just love programming like this. Fix one bug and cause two more. :wink:

Thanks for all the hard work.
User avatar
Kaiana
Elder Scribe
Posts: 148
Joined: Mon Jul 13, 2009 3:07 pm

Re: [EasyUO]TEST: KaianaUberLooter

Post by Kaiana »

More subs....need more subs....still working on it :) Don't use the script posted yet :)
♥Kaiana♥ - Administrator of the Heart

Yay for scripting and programming! :)
public bool EasyUOMastery = true;
private double CSharpSkillz = 30.0; //and rising!
Nelapsi
Legendary Scribe
Posts: 268
Joined: Thu Apr 15, 2010 11:16 am

Re: [EasyUO]TEST: KaianaUberLooter

Post by Nelapsi »

Kaiana wrote:More subs....need more subs....still working on it :) Don't use the script posted yet :)
Don't tell me you went to sleep rather then code.. *lowers his head in shame*


hehe
User avatar
Kaiana
Elder Scribe
Posts: 148
Joined: Mon Jul 13, 2009 3:07 pm

Re: [EasyUO]TEST: KaianaUberLooter

Post by Kaiana »

Ooook I think I fixed it, give it a shot as soon as I edit it after posting this :)

Remember that to use the new lockpicking function you need to either keep the picks in your main pack or keep them in one of your loot bags and KEEP THAT BAG OPEN. The script will stop working if it loses "sight" of the picks. I'm still trying to find a workaround for this as it shouldn't really be a problem...all of us use LastObject to use items in bags all the time, so I don't understand why the script is having trouble. I'm sure I'll figure it out :p

Oh and a quick note: "Locked Down & Secure" chests are now ignored by the script, but remember that this relies on the info for the chest having been received from the server. So if you teleport into your house, it may still start looting chests until the information from the server for those chests is received....nothing I can do about that. :( Well...short of adding a function to allow players to build a permanent ignore list....hmmmmm..........
♥Kaiana♥ - Administrator of the Heart

Yay for scripting and programming! :)
public bool EasyUOMastery = true;
private double CSharpSkillz = 30.0; //and rising!
User avatar
Tael
Elder Scribe
Posts: 166
Joined: Sun May 17, 2009 1:44 am

Re: [EasyUO]TEST: KaianaUberLooter

Post by Tael »

I've been trying out your looting script, and I think that it's very well done. There's that client crashing flaw with the "out of sight" thing, but that's the only problem I've encountered after a few hours of hunting. There must be a way around this problem. I'll continue to play around and see if I can come up with an idea to solve it. Otherwise, this looks like a pretty solid script.

Good job. Keep those scripts coming :)
Taelwrath - noobus perpetuus
Locked